search

ros-visualization / rviz

ROS 3D Robot Visualizer
BSD 3-Clause "New" or "Revised" License
822 stars 462 forks source link

Wrench visual deadzone #1081

Open goretkin opened 7 years ago

goretkin commented 7 years ago

I strongly dislike the behavior I'm getting of hiding the arrows if they become "shorter than they are wide". It seems like a good idea, but it should be optional and perhaps a separate parameter should decide the threshold.

It doesn't really seem like it's working as intended: https://youtu.be/6kV5kS81WsQ (notice how the deadzone really is too big. the arrows materialize out of nowhere, losing a huge range of sensitivity.)

Though from reading the code, I can't tell why: https://github.com/ros-visualization/rviz/blob/7970ba08cee3810cfa1609c3b0f5136970eb2f7c/src/rviz/default_plugin/wrench_visual.cpp#L63

v4hn commented 6 years ago

We just hit this bug too. I would propose to add a boolean flag "hide small forces" for this feature. Would that be ok for you @wjwwood ?

wjwwood commented 6 years ago

Fine by me.