search

ros-visualization / rviz

ROS 3D Robot Visualizer
BSD 3-Clause "New" or "Revised" License
846 stars 463 forks source link

this commit cause some interactive marker not working #1178

Closed zhuyiif closed 6 years ago

zhuyiif commented 6 years ago

this commit may be cause something wrong, https://github.com/ros-visualization/rviz/commit/73ad3e122283b2a8cbd116bda0b2ccf63c3b03e7, after I update rviz ,some interactive markers not working, even official tutorial e.g https://github.com/ros-visualization/visualization_tutorials.

rhaschke commented 6 years ago

Indeed this breaks interactive markers of MoveIt! as well. Previously, rviz was sloppy about unnormalized unit quaternions. Now it rejects those markers. It would be nice to have a smooth transition phase, where a warning is generated, the quaternion is normalized and processed anyway.

rhaschke commented 6 years ago

Actually, the offending PR is #1167.

zhuyiif commented 6 years ago

thanks for quick response :)

jecksonAD commented 6 years ago

Did the problem actually fixed? Because i still cannot using the interative marker in Rviz after the update

rhaschke commented 6 years ago

The problem is fixed and a release candidate is available via ros-shadow-fixed.

wjwwood commented 6 years ago

Closing this assuming the issue was actually fixed by now. Please comment if that's not the case.