ros-visualization / rviz

ROS 3D Robot Visualizer
BSD 3-Clause "New" or "Revised" License
844 stars 463 forks source link

ImageMarker message + rviz display (ros-pkg ticket #1298) #125

Open hershwg opened 12 years ago

hershwg commented 12 years ago

Something like:

byte CIRCLE=0
byte RECTANGLE=1
byte POLYGON=2
byte LINE_STRIP=3
byte LINE_LIST=4

...

byte ADD=0
byte REMOVE=1
Header header
string ns                     # namespace, used with id to form a unique id
int32 id                      # unique id within the namespace
int32 type                  # CIRCLE/LINE_STRIP/etc.
int32 action               # ADD/REMOVE
robot_msgs/Point position # 2D, in pixel-coords
float orientation        # angle in radians
robot_msgs/Vector3 scale
std_msgs/ColorRGBA color
bool fill

robot_msgs/Point points[]  # used for LINE_STRIP/LINE_LIST/etc.

Either broadcast on a topic inside the camera's namespace (/markers?) or matched by the frame id, on a global "image_markers" topic.

trac data:

hershwg commented 12 years ago

[berger] Milestone Release 0.1 deleted

hershwg commented 12 years ago

[tfoote] we're trying to get this

hershwg commented 12 years ago

[jfaust] The message is in, now rviz just needs to support it.

hershwg commented 12 years ago

[pantofaru] The ColoredLine(s) messages have been moved from the visualization_msgs package to the people package. They will be removed altogether when ImageView and rviz support ImageMarker(s).

hershwg commented 12 years ago

[jfaust] ColordLine(s) seem to still be in visualization_msgs... was that just a forgotten delete?

hershwg commented 12 years ago

[hersh] Caroline, is this still relevant?

Looks like someone wanted a way to draw 2D markers into camera/image displays in rviz.

hershwg commented 12 years ago

[pantofaru] I still think that being able to draw on images is important, and you might not always know the 3D position of the points to draw. For the moment I've hacked around it using OpenCV directly in my node, but that's not in the spirit of visualization in ROS.

I'm impartial as to how it's implemented, but yes, 2D drawing is useful.

dgossow commented 11 years ago

@tfoote @pantofaru Is this still an issue?

pantofaru commented 11 years ago

There still isn't a way to visualize a 2D marker in rviz, right? If not, then yes, this is still an issue. If you have an image-based object detection with no 3D information, it would still be nice to display it in the image view in rviz. This isn't a high priority, though.

cmpute commented 5 years ago

I really hope this could be implemented!

dgossow commented 5 years ago

I don't see why it could not be implemented. You can do it!

ijnek commented 2 years ago

It's been a while, but the new RQt Image Overlay Plugin may achieve what's being discussed here.

Although the implementation differs a lot from the suggestion in this issue, it achieves the overlay of debug drawings onto a streamed image. You are also not restricted to a set of predefined shapes as in the suggestion here.

amacneil commented 2 years ago

Since this issue is over 10 years old, it is worth pointing out that we support rendering 2d ImageMarker annotations in Foxglove Studio. See Image panel docs.