Tobias-Fischer
commented
4 years ago There is a race condition somewhere. This fixes the problem, but is not a proper fix - it would be great if someone with more rviz / ogre knowledge could give me a hint how a proper fix could look like:
diff --git a/src/rviz/default_plugin/image_display.cpp b/src/rviz/default_plugin/image_display.cpp
index 3b5d50ce..90252890 100644
--- a/src/rviz/default_plugin/image_display.cpp
+++ b/src/rviz/default_plugin/image_display.cpp
@@ -117,9 +117,9 @@ void ImageDisplay::onInitialize()
}
render_panel_ = new RenderPanel();
+ render_panel_->getRenderWindow()->addListener(this);
render_panel_->getRenderWindow()->setAutoUpdated(false);
render_panel_->getRenderWindow()->setActive(false);
-
render_panel_->resize(640, 480);
render_panel_->initialize(img_scene_manager_, context_);
@@ -136,12 +136,29 @@ ImageDisplay::~ImageDisplay()
{
if (initialized())
{
+ render_panel_->getRenderWindow()->removeListener(this);
+
delete render_panel_;
delete screen_rect_;
removeAndDestroyChildNode(img_scene_node_->getParentSceneNode(), img_scene_node_);
}
}
+void ImageDisplay::preRenderTargetUpdate(const Ogre::RenderTargetEvent& /*evt*/)
+{
+ static int count = 0;
+ if(count++>1) {
+ img_scene_node_->setVisible(true);
+ } else{
+ img_scene_node_->setVisible(false);
+ }
+}
+
+void ImageDisplay::postRenderTargetUpdate(const Ogre::RenderTargetEvent& /*evt*/)
+{
+ img_scene_node_->setVisible(false);
+}
+
void ImageDisplay::onEnable()
{
ImageDisplayBase::subscribe();
diff --git a/src/rviz/default_plugin/image_display.h b/src/rviz/default_plugin/image_display.h
index 88492c19..17e4baa8 100644
--- a/src/rviz/default_plugin/image_display.h
+++ b/src/rviz/default_plugin/image_display.h
@@ -59,7 +59,7 @@ namespace rviz
* \class ImageDisplay
*
*/
-class ImageDisplay : public ImageDisplayBase
+class ImageDisplay : public ImageDisplayBase, public Ogre::RenderTargetListener
{
Q_OBJECT
public:
@@ -71,6 +71,10 @@ public:
void update(float wall_dt, float ros_dt) override;
void reset() override;
+ // Overrides from Ogre::RenderTargetListener
+ void preRenderTargetUpdate(const Ogre::RenderTargetEvent& evt) override;
+ void postRenderTargetUpdate(const Ogre::RenderTargetEvent& evt) override;
+
public Q_SLOTS:
virtual void updateNormalizeOptions();
rhaschke
zzningxp
Describe your issue here and explain how to reproduce it.
Your environment
Output of
rosrun rviz rviz -l:Once I add an Image display:
Stacktrace:
Hi there, I built rviz using conda. It starts fine and seems to work fine, however if I try to add an Image it crashes with above error. It also happens with
export LIBGL_ALWAYS_SOFTWARE=1.OSX additional output: