[feature request] Better Qt5 support for Slots

ros-visualization / rviz

ROS 3D Robot Visualizer

BSD 3-Clause "New" or "Revised" License

831 stars 463 forks source link

[feature request] Better Qt5 support for Slots #1742

Closed kunaltyagi closed 1 year ago

kunaltyagi commented 2 years ago

Currently, all properties have a ctor which takes in slots as char*. However, since Qt5, there's an option to take slot as a member function or even a functor.

Links

Qt4 details
Qt5 details

Would a PR touching multiple property and derived class ctor be entertained?

rhaschke commented 2 years ago

A corresponding PR supporting the new scheme is highly welcome. The old scheme should be still supported of course. I'm looking forward to this contribution :smile: