ros-visualization / rviz

ROS 3D Robot Visualizer
BSD 3-Clause "New" or "Revised" License
831 stars 463 forks source link

Add better support for Qt5 style slots #1743

Closed kunaltyagi closed 1 year ago

kunaltyagi commented 2 years ago

Closes #1742

Please check the proposed changes. I'll modify other properties once this is considered as an appropriate direction

API: adds ctor in properties ABI: no change, except as indicated by API

Description

Properties now have a ctor which allows providing normal C++ function pointers and lambda variables instead of Q_SLOTS

Checklist

kunaltyagi commented 2 years ago

CI fails due to outstanding warnings. Most are from system headers

rhaschke commented 1 year ago

Sorry for the long delay on this. I didn't had time to look into that before. I noticed that your approach only supports lambdas, but not pointer-to-member functions as slots. See #1790 for an alternative approach.

rhaschke commented 1 year ago

@kunaltyagi, #1790 is ready for review and testing now. Closing here.