search

ros-visualization / rviz

ROS 3D Robot Visualizer
BSD 3-Clause "New" or "Revised" License
831 stars 463 forks source link

Fix segfaults of PointCloud-like displays during reloading #1754

Closed rhaschke closed 2 years ago

rhaschke commented 2 years ago

This should fix #1753 (but is not tested yet). It ensures:

  1. that TimePanel::onTimeSignal validates the sender display
  2. that a Pointcloud-like display unsubscribed before destroying PointCloudCommon

@ysl-design, could you please validate this fixup?

rhaschke commented 2 years ago

@ysl-design, could you please give this another try?