ros-visualization / rviz

ROS 3D Robot Visualizer
BSD 3-Clause "New" or "Revised" License
831 stars 463 forks source link

Parts of EnumProperty are hidden when the display width is less than the string length. #1778

Closed ysl-design closed 1 year ago

ysl-design commented 1 year ago

Hi, I found that in the noetic version, when EnumProperty is selected, parts of it are hidden when the display width is less than the length of the string. image This problem does not occur in the melodic version, probably because the qt version is different. In the melodic version, like this: image I think adding cb->setSizeAdjustPolicy(QComboBox::AdjustToMinimumContentsLengthWithIcon) to the EnumProperty::createEditor function, the same settings as in EditableEnumProperty::createEditor should solve this problem, don't you think?

Your environment

rhaschke commented 1 year ago

You are right, non-editable EnumProperties don't require the dropdown icon to be visible as you can click everywhere in the combobox to open the dropdown. Enforcing to show the icon reduces readability in my opinion:

image vs. image

ysl-design commented 1 year ago

Yes, this will show more information. Okay, I'll close the issue