ros-visualization / rviz

ROS 3D Robot Visualizer
BSD 3-Clause "New" or "Revised" License
791 stars 459 forks source link

Replace obsolete QPixmap::grabWindow() with QScreen::grabWindow() #1794

Closed vineet131 closed 1 year ago

vineet131 commented 1 year ago

Referring to the document below and based on the warnings I am getting at runtime, we replace QPixmap with QScreen: https://doc.qt.io/qt-5/qpixmap-obsolete.html

Description

Referring to the document below and based on the warnings I am getting at runtime, we replace QPixmap with QScreen: https://doc.qt.io/qt-5/qpixmap-obsolete.html

Checklist

rhaschke commented 1 year ago

Thanks for pointing out this deprecation in newer versions of Qt5. Unfortunately, this PR didn't even compile as is.

vineet131 commented 1 year ago

Thanks for pointing out this deprecation in newer versions of Qt5. Unfortunately, this PR didn't even compile as is.

Thanks for the fixup. I couldn't compile it at home since I am not running ROS1 at home.