Fix #1825/#1830: segfault when hiding deleted properties

ros-visualization / rviz

ROS 3D Robot Visualizer

BSD 3-Clause "New" or "Revised" License

791 stars 459 forks source link

Fix #1825/#1830: segfault when hiding deleted properties #1831

Closed rhaschke closed 1 month ago

rhaschke commented 1 month ago

When a hidden property was configured to process propertyHiddenChanged and got deleted in between, this was causing a segfault. We need to protect the slot/functor from being called when the property is deleted.

Fixes #1830.

Achllle commented 1 month ago

I can confirm this fixes the issues I encountered, thank you for fixing this so quickly!