search

ros / actionlib

Provides a standardized interface for interfacing with preemptable tasks. Examples of this include moving the base to a target location, performing a laser scan and returning the resulting point cloud, detecting the handle of a door, etc.
http://www.ros.org/wiki/actionlib
96 stars 155 forks source link

Fix constructors of SimpleActionServer #194

Closed Rayman closed 3 years ago

Rayman commented 3 years ago

PR #185 introduced a regression where some of the constructors didn't compile anymore. This issue is that boost::function can't be instantiated or compared to nullptr.

I've reverted some of the changes so that it compiles again. I've also added some unit tests so that this doesn't happen again.

EDIT: I could not add unit tests for the constructors that were failing because they were deprecated and this PR would introduce compile warnings.

Rayman commented 3 years ago

That's a good idea, I'll try that

Rayman commented 3 years ago

I've added tests for the deprecated constructors with a gcc pragma