Lifecycle support 2 - Githubissues

ros / bond_core

Maintains a bond (i.e. heart beat ) between ROS nodes and provides feedback when the bond is broken

http://www.ros.org/wiki/bond_core

35 stars 63 forks source link

Lifecycle support 2 #67

Closed SteveMacenski closed 4 years ago

SteveMacenski commented 4 years ago

Supersedes https://github.com/ros/bond_core/pull/64 to:

Enable lifecycle nodes in ROS2
Fix ROS2 porting issues
Fix ROS2 WaitUntilXYZ() functions with spins on nodes already spinning (requirement for this to work)
Tested to be actualy working now & integrated into Nav2
No reduced capability
Removes a number of crashing problems introduced in porting

SteveMacenski commented 4 years ago

Whoops, see the commit https://github.com/ros/bond_core/pull/67/commits/f72af40e830404ca765e41b37d78d39c0db30418, I didn't push it to remote, I had already done that :-)

SteveMacenski commented 4 years ago

Pinging @mjcarroll as listed maintainer, can we get a review?

This work has been merged in and used on nav2 for about a week now without any issues. I think this is safe for a review for inclusion

SteveMacenski commented 4 years ago

Pinging @mjcarroll

mjcarroll commented 4 years ago

Pong. I'm reviewing.

ros-discourse commented 4 years ago

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2020-08-20/16063/1

SteveMacenski commented 4 years ago

@mjcarroll pinging again

mjcarroll commented 4 years ago

@SteveMacenski would you like this to be released into rolling?

SteveMacenski commented 4 years ago

I don't require it, but might be a good idea. If nothing else, having it in Foxy would be our immediate needs. Right now, we don't use Rolling in Nav2 (frankly, the emails from occasional failures in just image_pipeline is prohibitive for me to support rolling releases.).