search

ros / class_loader

ROS-independent library for dynamic class (i.e. plugin) introspection and loading from runtime libraries
http://www.ros.org/wiki/class_loader
35 stars 95 forks source link

Reduce number of threads spun up on ARMHF platforms in stress test #128

Closed emersonknapp closed 5 years ago

emersonknapp commented 5 years ago

Part of https://github.com/ros2/ros2/issues/721

In armhf platforms, the std::thread constructor starts to raise Resource temporarily unavailable at ~512 threads.

https://ci.ros2.org/job/ci_linux-armhf/lastCompletedBuild/testReport/(root)/class_loader/ - reproduces reliably on an AWS Graviton instance.

For these platforms, reduce the number of threads created to a level where (experimentally) it never fails.

emersonknapp commented 5 years ago

@clalancette do you know who would be best to review this change? it's part of the armhf support as noted above

clalancette commented 5 years ago

@clalancette do you know who would be best to review this change? it's part of the armhf support as noted above

It looks like @nuclearsandwich is the maintainer here: https://github.com/ros/class_loader/blob/melodic-devel/package.xml#L9

I'll also do a quick review.

emersonknapp commented 5 years ago

Hey @nuclearsandwich, welcome back :) looking forward to hearing your thoughts on this

emersonknapp commented 5 years ago
emersonknapp commented 5 years ago

@nuclearsandwich ping