search

ros / class_loader

ROS-independent library for dynamic class (i.e. plugin) introspection and loading from runtime libraries
http://www.ros.org/wiki/class_loader
35 stars 95 forks source link

Clean up and improve documentation #156

Closed ahcorde closed 4 years ago

ahcorde commented 4 years ago

Clean up and improve documentation

@brawner

Signed-off-by: ahcorde ahcorde@gmail.com

ahcorde commented 4 years ago

I removed two methods. Running CI in for all the pacakges to check that these symbols are not used. And running test only for class_loader

brawner commented 4 years ago

Is there a reason you're removing the methods? I thought code was under an API freeze?

ahcorde commented 4 years ago

I forgot to removed these headers when I changed Poco for rcpputils::SharedLibrary. There is no implementation for these methods. Should we keep it?

ahcorde commented 4 years ago

@wjwwood can you have a look ?

ahcorde commented 4 years ago