search

ros / class_loader

ROS-independent library for dynamic class (i.e. plugin) introspection and loading from runtime libraries
http://www.ros.org/wiki/class_loader
35 stars 95 forks source link

Update Quality Declaration to reflect QL 2 (#160). #160

Closed hidmic closed 4 years ago

hidmic commented 4 years ago

Precisely what the title says.

Blast545 commented 4 years ago

I'd add a couple of comments I found while reviewing the file, please address them, github interface didn't alllow me to comment directly in the file:

Update 2.i to: All changes will occur through a pull request, check the ROS 2 Developer Guide for additional information.

Update text in 3.i to link to features described in README.md file.

Update 3.ii to say "There is documentation for all of the public API using docblocks"

Blast545 commented 4 years ago

And this should be merged after rcpputils is updated to Q2 as well.

chapulina commented 4 years ago

And this should be merged after rcpputils is updated to Q2 as well.

Good call, I missed that when looking at the dependency graph

hidmic commented 4 years ago

Alright, may I ask anyone of the maintainers to merge this PR?

hidmic commented 4 years ago

@nuclearsandwich ping.

nuclearsandwich commented 4 years ago

Thanks to the other reviewers. Together with my own review this is ready for merge.