search

ros / class_loader

ROS-independent library for dynamic class (i.e. plugin) introspection and loading from runtime libraries
http://www.ros.org/wiki/class_loader
35 stars 95 forks source link

Method createSharedInstance missing in ROS2 branches #165

Closed Levi-Armstrong closed 4 years ago

Levi-Armstrong commented 4 years ago

When porting to ROS2 we noticed that createSharedInstance was missing from the API for the ROS2 version; was this intentional? If not, we will create a PR adding it.

dirk-thomas commented 4 years ago

While the methods have different names on the ROS 2 branches they should offer the same functionality:

https://github.com/ros/class_loader/blob/9c0875c8a861b577e8d6e4e848cee3646a14c063/include/class_loader/class_loader.hpp#L124-L125

https://github.com/ros/class_loader/blob/9c0875c8a861b577e8d6e4e848cee3646a14c063/include/class_loader/class_loader.hpp#L146-L147

https://github.com/ros/class_loader/blob/9c0875c8a861b577e8d6e4e848cee3646a14c063/include/class_loader/class_loader.hpp#L169-L170

Levi-Armstrong commented 4 years ago

Ah, I missed the fact that createInstance returned a shared pointer. Thank you.