Fix ternary null check found by clang static analysis

ros / class_loader

ROS-independent library for dynamic class (i.e. plugin) introspection and loading from runtime libraries

http://www.ros.org/wiki/class_loader

35 stars 95 forks source link

Fix ternary null check found by clang static analysis #176

Closed brawner closed 3 years ago

brawner commented 3 years ago

This null check logic is backwards. This was easily found by scan-build from clang static analysis. After this PR, class_loader builds cleanly with scan-build.

Signed-off-by: Stephen Brawner brawner@gmail.com

brawner commented 3 years ago

This PR will need to be backported to relevant branches.

brawner commented 3 years ago

Running on just ci.ros2.org for now, I'll have to rebase and merge this commit as it includes some fixes for travis/appveyor. Testing --packages-select class_loader.

Linux
Linux-aarch64
macOS
Windows

brawner commented 3 years ago

@clalancette I don't think the travis and appveyor jobs are gonig to work with just simple updates to travis/appveyor configs. The Rpr job succeeds, and the CI jobs succeeded. The windows job shows some warnings about deprecations of cmake versions which we'll need to address elsewhere and are unrelated to this PR.

I dont' have merge privlegeges, are you able to merge it? I removed the commit for travis/appveyor updates so this can be squash merged

clalancette commented 3 years ago

I'll go ahead and merge it. @brawner Can you open an issue to look into fixing the Travis and Appveyor jobs? It looks like they've been consistently failing since June.

brawner commented 3 years ago

See https://github.com/ros/class_loader/issues/164