Install includes to include/${project_name} and use more modern CMake

ros / class_loader

ROS-independent library for dynamic class (i.e. plugin) introspection and loading from runtime libraries

http://www.ros.org/wiki/class_loader

34 stars 95 forks source link

Closed sloretz closed 2 years ago

sloretz commented 2 years ago

Part of ros2/ros2#1150

This installs includes to include/${PROJECT_NAME} to mitigate include directory search order issues when overriding packages in desktop.

Part of ament/ament_cmake#365

This removes ament_export_libraries and ament_export_include_directories as they're redundant with the exported CMake targets.

Part of ament/ament_cmake#292

This replaces an ament_target_dependencies() call with target_link_libraries().

sloretz commented 2 years ago

CI (repos file build: --packages-above-and-dependencies class_loader test: --packages-select class_loader)

sloretz commented 2 years ago

All of the test failures are due to cpplint include order, otherwise CI LGTM.

jacobperron commented 2 years ago

cpplint errors are addressed on ros2, so I think we can merge this PR.