Fix include order for cpplint

ros / class_loader

ROS-independent library for dynamic class (i.e. plugin) introspection and loading from runtime libraries

http://www.ros.org/wiki/class_loader

34 stars 95 forks source link

Fix include order for cpplint #192

Closed jacobperron closed 2 years ago

jacobperron commented 2 years ago

Relates to https://github.com/ament/ament_lint/pull/324

jacobperron commented 2 years ago

The appveyor job has been failing since August 2020 (https://github.com/ros/class_loader/issues/164). Perhaps we should just remove it considering we have Windows coverage via ci.ros2.org?

gbiggs commented 2 years ago

CI:

Linux
Linux (aarch64)
Windows

gbiggs commented 2 years ago

What is the Appveyor job supposed to do?

jacobperron commented 2 years ago

What is the Appveyor job supposed to do?

Test the package on Windows, I suppose. It was added in 2015 (https://github.com/ros/class_loader/pull/28); though it doesn't predate ci.ros2.org, so maybe it was supposed to provide additional test coverage. @wjwwood I know it's ancient history, but do you know the origin story?

wjwwood commented 2 years ago

Not sure, but it may have been just covering class_loader itself before we were running ci.ros2.org on everything.