search

ros / class_loader

ROS-independent library for dynamic class (i.e. plugin) introspection and loading from runtime libraries
http://www.ros.org/wiki/class_loader
35 stars 95 forks source link

Include library name into library unload exceptions to make debugging easier. #194

Closed remod closed 2 years ago

gbiggs commented 2 years ago

I'm getting test failures when I run the tests after merging this PR. Can you please check that the tests have been updated appropriately?

remod commented 2 years ago

If you are speaking about the number of errors similar to the one posted blow, I think this is an issue which is unrelated to this PR.

[ RUN      ] ClassLoaderUniquePtrTest.basicLoad
/home/remod/workspaces/behavior_coredump/catkin_ws/src/class_loader/test/unique_ptr_test.cpp:57: Failure
Failed
ClassLoaderException: Could not load library (Poco exception = libclass_loader_TestPlugins1.so: cannot open shared object file: No such file or directory)

[  FAILED  ] ClassLoaderUniquePtrTest.basicLoad (0 ms)

Can you confirm that

catkin clean -y
catkin build class_loader
catkin run_tests class_loader

fails, and 

catkin clean -y
catkin build class_loader
catkin run_tests class_loader
catkin build class_loader
catkin run_tests class_loader

succeeds on the 2nd run_tests?

I assume the reason is that the test plugins are not exported immediately and the tests do not find them yet?

gbiggs commented 2 years ago

Yep, that looks to be it. Thanks for checking.