ros / cmake_modules

A common repository for CMake Modules which are not distributed with CMake but are commonly used by ROS packages.
BSD 3-Clause "New" or "Revised" License
33 stars 51 forks source link

FindPoco.cmake not found #28

Open spaghetti- opened 9 years ago

spaghetti- commented 9 years ago

I can see the merge but its not reflected in the repository. Any reasons?

EDIT: only the cmake_modules pulled by rosdep doesn't reflect the change.

spaghetti- commented 9 years ago

After a rebuild it picked it up, however the FindPoco file reflects old versions of Poco. 1.4.7p1 is the latest stable release. Is there any way to automatically pick up the libraries rather than having the user manually enter the latest release himself?

wjwwood commented 9 years ago

The FindPoco.cmake was merged, but not released yet. That's why it isn't in the version pulled by rosdep.

@esteve can you update the FindPoco.cmake to either support the latest version of Poco available or make it so that it works with some sort of regular expression and won't have to be updated in the future? See:

https://github.com/ros/cmake_modules/blob/0.3-devel/cmake/Modules/FindPoco.cmake#L70-77