search

ros / cmake_modules

A common repository for CMake Modules which are not distributed with CMake but are commonly used by ROS packages.
BSD 3-Clause "New" or "Revised" License
33 stars 51 forks source link

provide a FindYamlCpp.cmake #30

Open vrabaud opened 9 years ago

vrabaud commented 9 years ago

seems useful after: https://github.com/ros-perception/image_common/pull/31

(plus, there were already problems between 0.3 and 0.5)

There is an open issue upstream: https://code.google.com/p/yaml-cpp/issues/detail?id=127

Even though there is some CMake code here: https://code.google.com/p/yaml-cpp/source/browse/

Should we comply to their notation ? YAML_CPP_INCLUDE_DIR and not YAML_CPP_INCLUDE_DIRS

vrabaud commented 9 years ago

Proof of concept that works for me here: https://github.com/ros/cmake_modules/pull/31

wjwwood commented 9 years ago

Ok, I'll have a look tomorrow. Sorry for the delay, this got lost in my inbox noise.

wjwwood commented 9 years ago

We can have a FindYAMLCpp.cmake, but we should fix the logic so it actually makes sense first.