ros / cmake_modules

A common repository for CMake Modules which are not distributed with CMake but are commonly used by ROS packages.
BSD 3-Clause "New" or "Revised" License
33 stars 51 forks source link

Add CMake searcher for DepthSenseSDK. #32

Closed kamiccolo closed 7 years ago

kamiccolo commented 9 years ago

Adds CMake module for searching for DepthSenseSDK includes and libraries.

What the heck is that? DepthSenseSDK --- product of SoftKinetic, developed as an interface for their stereo-cameras. Those are use by at least couple of ROS users I know.

Oh, besides, it's also released for Windows, so, adding relevant searcher rules.

wjwwood commented 9 years ago

Thanks for the pull request, but I won't be releasing any changes to the 0.2-devel branch since that is Groovy only and Groovy has been EOL'ed. I'd happily take the new module for 0.4-devel and ROS Jade. I would consider a pull request for 0.3-devel which is for ROS Hydro and Indigo, though I'm more careful about merging to that branch and I make releases from that branch less frequently.

kamiccolo commented 9 years ago

Thanks for response. I was aware of 0.2-devel being the one for Groovy which was EOLed, just thought of developers building packages from source them selves. And this might be a handy addition despite not getting pulled into the *.deb repository.

Will apply the mentioned pull-request to 0.3-devel and 0.4-devel respectively. Besides, also forgot README additions :}

wjwwood commented 7 years ago

I'll merge this, but I won't be releasing it.

kamiccolo commented 7 years ago

Still thanks :)