search

ros / common_msgs

Commonly used messages in ROS. Includes messages for actions (actionlib_msgs), diagnostics (diagnostic_msgs), geometric primitives (geometry_msgs), robot navigation (nav_msgs), and common sensors (sensor_msgs), such as laser range finders, cameras, point clouds.
http://wiki.ros.org/common_msgs
179 stars 191 forks source link

add mingration rule, copied from common_msgs-1.6 #102

Closed k-okada closed 6 years ago

k-okada commented 7 years ago

migration rule exists until common_msgs-1.6 (https://github.com/ros/common_msgs/blob/common_msgs-1.6/sensor_msgs/manifest.xml#L15) has been removed , when converting to catkin may be this is rarely used, but I found we need this on http://wiki.ros.org/stereo_image_proc/Tutorials/ChoosingGoodStereoParameters

k-okada commented 7 years ago

Does catkin_lint approve?

may be it' ok

k-okada@p40-yoga:~/catkin_ws/ws_migration/src/common_msgs/sensor_msgs$ catkin_lint -W2
sensor_msgs: test/CMakeLists.txt(2): error: missing test_depend on 'rosunit'
sensor_msgs: test/CMakeLists.txt(3): error: missing test_depend on 'rosunit'
sensor_msgs: notice: package description starts with boilerplate 'This package'
sensor_msgs: test/CMakeLists.txt(2): notice: use ${PROJECT_NAME} instead of 'sensor_msgs'
sensor_msgs: test/CMakeLists.txt(3): notice: use ${PROJECT_NAME} instead of 'sensor_msgs'
catkin_lint: checked 1 packages and found 5 problems
jack-oquin commented 7 years ago

I'm inclined to ignore those notices.

The two errors look like preexisting problems, but it probably makes sense to fix them now, anyway.

k-okada commented 7 years ago

@jack-oquin see https://github.com/ros/common_msgs/pull/103 for fix warning of catkin_lint