search

ros / common_msgs

Commonly used messages in ROS. Includes messages for actions (actionlib_msgs), diagnostics (diagnostic_msgs), geometric primitives (geometry_msgs), robot navigation (nav_msgs), and common sensors (sensor_msgs), such as laser range finders, cameras, point clouds.
http://wiki.ros.org/common_msgs
186 stars 190 forks source link

Update BatteryState.msg with temperatures #140

Closed reinzor closed 4 years ago

reinzor commented 5 years ago

Resolves https://github.com/ros/common_msgs/issues/139

reinzor commented 5 years ago

ping

tfoote commented 5 years ago

This looks like a reasonable addition. Changing a core message like this is not something that we can do during a release cycle so we will need to target Noetic. And it would be good to make sure to clearly document any migration requirements for existing users, both for requirements for their code base as well as bag migration rules for logged data.

reinzor commented 4 years ago

Can this be closed or do you still require this?

clalancette commented 4 years ago

I think this is a good idea to do; thanks for pinging. Now that we are heading towards noetic, I'd create a new branch (noetic-devel), retarget this there, and then merge it. @tfoote any thoughts? If not, I'll just go ahead and do it.

clalancette commented 4 years ago

All right, I've created a new noetic-devel branch, then retargeted this PR at that branch. I'm going to go ahead and merge it now. We'll also need an update to https://github.com/ros/rosdistro/blob/master/noetic/distribution.yaml to update the branches there, which I'll do shortly.

reinzor commented 4 years ago

Thanks!

tfoote commented 4 years ago

Branch change upstream for cross reference. https://github.com/ros/rosdistro/pull/24094

dirk-thomas commented 4 years ago

This has not been released into Noetic. Doing so after the release breaks the interface.

gavanderhoorn commented 4 years ago

Just to keep things connected: this PR has come up on ROS Answers: How to receive standard message that has changed format in noetic?.