search

ros / common_msgs

Commonly used messages in ROS. Includes messages for actions (actionlib_msgs), diagnostics (diagnostic_msgs), geometric primitives (geometry_msgs), robot navigation (nav_msgs), and common sensors (sensor_msgs), such as laser range finders, cameras, point clouds.
http://wiki.ros.org/common_msgs
177 stars 191 forks source link

Fix for: Add an OdometryWithAcceleration message #146

Open m-naumann opened 5 years ago

m-naumann commented 5 years ago

Fix acceleration message

Keep the name twist for velocities

Add documentation for treatment of incomplete information

tfoote commented 5 years ago

Sorry I edited my comments as I didn't realize that this was modifying the proposal not the core messages. But the semantic meaning and clarity comments still hold as well as the location of the covariance documentation.

m-naumann commented 5 years ago

No worries. I tried to make my point in the code comments, but it's probably a matter of taste whether to start improving the naming but therefore mixing old and new, or whether to only improve naming for entirely new messages.

About the covariance: If there is another convention/documentation anywhere, let me know. That was the only one I found, and I changed it to separate treatment of single entries as that's at least in the automated driving context very useful.

EDIT:

as well as the location of the covariance documentation.

I agree, that's probably worth a PR to update the documentation of the three messages itself. Maybe you can shortly tell me whether I should prepare a PR for those 3.