search

ros / common_msgs

Commonly used messages in ROS. Includes messages for actions (actionlib_msgs), diagnostics (diagnostic_msgs), geometric primitives (geometry_msgs), robot navigation (nav_msgs), and common sensors (sensor_msgs), such as laser range finders, cameras, point clouds.
http://wiki.ros.org/common_msgs
183 stars 190 forks source link

Added comment to document new Rviz Marker action #38

Closed davetcoleman closed 10 years ago

davetcoleman commented 10 years ago

This does not change the MD5 sum of common_msgs, but merely documents a new feature that can be optionally used.

I do advocate we enable this action type in ROS-J.

This change documents https://github.com/ros-visualization/rviz/pull/781

mikeferguson commented 10 years ago

@davetcoleman Should the comment on the "action" field also be updated? There isn't really any description up above that ADD/DELETE/MODIFY and now DELETE_ALL are intended for that particular field.

mikeferguson commented 10 years ago

+1 other than that.

tfoote commented 10 years ago

Good point @mikeferguson It would be great to put a comment above the list for which enums are for which fields. Otherwise looks good +1

davetcoleman commented 10 years ago

Comment added

hersh commented 10 years ago

+1

davetcoleman commented 10 years ago

@tfoote this is ready to merge.

tfoote commented 10 years ago

Merged with a rebase on the last pull-request https://github.com/ros/common_msgs/commit/5f14bddf46841943ab22a5014c261b345bcca46c

davetcoleman commented 8 years ago

i was just checking if this was ever updated for ROS-J, and I see it was. thanks @tfoote !