fix critical bug with operator+

ros / common_msgs

Commonly used messages in ROS. Includes messages for actions (actionlib_msgs), diagnostics (diagnostic_msgs), geometric primitives (geometry_msgs), robot navigation (nav_msgs), and common sensors (sensor_msgs), such as laser range finders, cameras, point clouds.

http://wiki.ros.org/common_msgs

179 stars 191 forks source link

fix critical bug with operator+ #47

Closed mikeferguson closed 9 years ago

mikeferguson commented 9 years ago

The operator+ doesn't actually increment, since it references the wrong datachar (the non-incremented one). This was found while debugging https://github.com/ros-planning/moveit_ros/issues/505

vrabaud commented 9 years ago

+1, shit. Will add a test for that before we re-release

davetcoleman commented 9 years ago

+1 hurray!

vrabaud commented 9 years ago

@tfoote that requires a new release. Can I ?

tfoote commented 9 years ago

https://github.com/ros/rosdistro/pull/6086