search

ros / common_msgs

Commonly used messages in ROS. Includes messages for actions (actionlib_msgs), diagnostics (diagnostic_msgs), geometric primitives (geometry_msgs), robot navigation (nav_msgs), and common sensors (sensor_msgs), such as laser range finders, cameras, point clouds.
http://wiki.ros.org/common_msgs
179 stars 191 forks source link

Changes the MODIFY value to 1 in Marker.msg struct #92

Closed carlosjoserg closed 7 years ago

carlosjoserg commented 7 years ago

Just found it while reading the docs.-

I don't know when it'd be useful to have a MODIFY action type, but I guess it should have a different value at least, right?

Probably nobody ever used this functionality before... maybe it was already expected that ADD and MODIFY should behave the same?

PR-ing just in case

tfoote commented 7 years ago

modify was deprecated and merged with add. action: 0 = add/modify, 1 = (deprecated), 2 = delete, New in Indigo 3 = deleteall

It's documented here.

carlosjoserg commented 7 years ago

:+1: I missed that

tfoote commented 7 years ago

No worries, it took me several searches to find that, but I had a guess what I was looking for.