ros / common_msgs

Commonly used messages in ROS. Includes messages for actions (actionlib_msgs), diagnostics (diagnostic_msgs), geometric primitives (geometry_msgs), robot navigation (nav_msgs), and common sensors (sensor_msgs), such as laser range finders, cameras, point clouds.
http://wiki.ros.org/common_msgs
179 stars 191 forks source link

Why DELETEALL is disable for ros indigo? #98

Closed talregev closed 7 years ago

talregev commented 7 years ago

In this line, You disable DELETEALL enum.
I am using indigo ros. And in the wiki, you mention DELETEALL functionality.
I was surprise that in there is not DELETEALL enum value on the code.
So I hack the value from the wiki, and it work! :)
Why not enable it for all?

tfoote commented 7 years ago

The enum value was decided to be added after indigo was already released. The message definition was not changed in indigo to maintain stability. The comment was added so that you could use the functionality as you already have.

If we changed the enum, the md5sum of the message would be different and it would invalidate all bag files recorded as well as making it such that indigo packages from before or after the change might not be able to talk to each other. (Most commonly this will hit people playing back a bag file recorded before the change and a subscriber who we compiled after the change.)