Mismatch between actionlib_tutorials wiki and this repository

[scpeters]

I just noticed there's some mismatch between the wiki and this repository. I'm willing to help clean it up if I get some feedback on how it should be fixed.

• The actionlib_tutorials page says to create a catkin package called learning_actionlib, while this repository has a package called actionlib_tutorials.
• The first two beginner tutorials (Fibonacci c++ server and Fibonacci c++ client) use the learning_actionlib package name.
• The two python beginner tutorials use the actionlib_tutorials package name. Also, those python scripts are not contained in this git repository.

Should the tutorial recommend to the user how to recreate the contents of the actionlib_tutorials package in this repository?

[scpeters]

forgot some tutorial links:

• python Fibonacci server
• python Fibonacci client

[wjwwood]

My guess is that someone changed the name of the package that the user creates so that it doesn't interfere with this package which can be installed from apt-get and the Python tutorial never got updated. The Python tutorial is also out of date because it still has the import roslib; roslib.load_manifest('actionlib_tutorials') line at the top of the Python script, which is only needed for rosbuild and not for catkin. I'd suggest updating the Python tutorial to be in line with the introduction tutorial and the C++ parts of the tutorial.

[scpeters]

Do you suggest that we keep different package names between the wiki and this repository? I was hoping to delete one copy of the code from the wiki and include it from here instead, but that isn't possible if they are using different package names.

We can also keep it as is (with two copies of the code) if that's preferred.

[wjwwood]

No, the idea is that the package the user creates is not hosted anywhere and that it is identical, except in name, to the one here on github. The one here on github is the "answer". But I think that we could go back to using just the actionlib_tutorials name and drop the learning_actionlib stuff. I'm not sure who added that in the first place, and I'm only guessing at their motives for doing so.

[130s]

I just stumbled upon this ticket where I think I'm partly responsible for the issue discussed. I tracked back the history and figured out:

• Both C++ and Python tutorials started off using learning_actionlib, instead of actionlib_tutorials.
• When I added catkin version of Python tutorials, I replaced learning_actionlib with actionlib_tutorials.
• The actionlib_tutorials package, which is now hosted on this repo, has always been named actionlib_tutorials (eg. init commit on this github repo) (except for short term it was renamed (between this and this)).

the idea is that the package the user creates is not hosted anywhere and that it is identical, except in name, to the one here on github. The one here on github is the "answer". But I think that we could go back to using just the actionlib_tutorials name and drop the learning_actionlib stuff.

+1, and I've just added all the necessary changes on the tutorials. Now hopefully there's no learning_actionlib stuff on the tutorials.

the Python tutorial never got updated. The Python tutorial is also out of date because it still has the import roslib; roslib.load_manifest('actionlib_tutorials') line at the top of the Python script, which is only needed for rosbuild and not for catkin.

This should also be fixed now.

[scpeters]

I still see a few instances of learning_actionlib in the following wiki pages:

• http://wiki.ros.org/actionlib_tutorials
• http://wiki.ros.org/actionlib_tutorials/Tutorials/RunningServerAndClient
• http://wiki.ros.org/actionlib_tutorials/Tutorials/SimpleActionServer%28GoalCallbackMethod%29
• http://wiki.ros.org/actionlib_tutorials/Tutorials/SimpleActionClient%28Threaded%29
• http://wiki.ros.org/actionlib_tutorials/Tutorials/RunningServerAndClientWithNodes

[130s]

@scpeters Thanks for the check, I'm working on it now.

[130s]

Hopefully done.

[scpeters]

thanks!