search

ros / common_tutorials

ROS common_tutorials stack migrated from https://code.ros.org/svn/ros-pkg/stacks/common_tutorials/branches/common_tutorials-0.1/
62 stars 59 forks source link

class_loader dependency is added to nodelet_tutorial_math package #6

Closed muratsevim closed 11 years ago

muratsevim commented 11 years ago

Fixes the undefined symbol errors when linking libnodelet_math library on Mac OS X

wjwwood commented 11 years ago

What version of ROS? This was fixed upstream in Hydro. AFAIK.

muratsevim commented 11 years ago

Oh! I was working with Groovy. So will linking work in Hydro without adding the dependency? If yes, is there an easy way to get the fix without completely moving to Hydro?

wjwwood commented 11 years ago

@muratsevim I think the fix is in pluginlib, let me see if I can find it.

wjwwood commented 11 years ago

Nope, it was in nodelet:

https://github.com/ros/nodelet_core/commit/70f4e26e399c6b211d51f04113014a9b880c3f11

wjwwood commented 11 years ago

I can probably backport it, or you can just apply the patch manually.

This is the important change here:

https://github.com/ros/nodelet_core/commit/70f4e26e399c6b211d51f04113014a9b880c3f11#L0R19

wjwwood commented 11 years ago

Adding it here is actually incorrect, as this package doesn't directly use class_loader, the fact that you need class_loader here is an implementation detail of pluginlib.

wjwwood commented 11 years ago

Thanks for pointing it out, I'll probably do the backport, but I can't say when we'll release nodelet_core for Groovy again.

muratsevim commented 11 years ago

Thanks! That helped a lot and probably saved me from adding the dependency to other packages. I will remove the dependency on nodelet_tutorial_math and apply the patch manually.

wjwwood commented 11 years ago

https://github.com/ros/nodelet_core/issues/6

wjwwood commented 11 years ago

I went ahead and released nodelet_core, so you should be able to get the new released version 0.7.16 too.

https://github.com/ros/rosdistro/pull/1533