search

ros / console_bridge

A ROS-independent package for logging that seamlessly pipes into rosconsole/rosout for ROS-dependent packages.
BSD 3-Clause "New" or "Revised" License
22 stars 62 forks source link

Fix pkg-config file to respect ${prefix} variable for libs and headers #11

Closed j-rivero closed 10 years ago

j-rivero commented 10 years ago

Current pkg-config file does not include the ${prefix} pkg-config variable so the final result is not an absolute path but a relative one ('lib/').

Error was detected while testing sdformat using urdfdom pkg-config file, which will use console_bridge and end up showing errors like this. Fixing the console bridge pkg-config manually, with this pull request changes, fix the issue for me.

I believe that was @thomas-moulard who introduced the changes to the pkg config file.

thomas-moulard commented 10 years ago

I plead guilty on this one. However the solution proposed here would be better be replaced by @CMAKE_INSTALL_FULL_LIBDIR@ and @CMAKE_INSTALL_FULL_INCLUDEDIR@ as GNUInstallDirs.cmake ensures that those variables are fully qualified path.

j-rivero commented 10 years ago

hehe, I knew that was a good option to CC you on this one. I've updated the pull request with your recommendation. Thanks.

BTW, I will add the patch to debian-science until we have a new release of console-bridge with this fix.