search

ros / console_bridge

A ROS-independent package for logging that seamlessly pipes into rosconsole/rosout for ROS-dependent packages.
BSD 3-Clause "New" or "Revised" License
22 stars 62 forks source link

ABI compatibility broken #14

Closed jbohren closed 8 years ago

jbohren commented 10 years ago

Whatever changed in rosconsole recently broke ABI compatiblity. Just a head's up.

j-rivero commented 10 years ago

This is something to consider, specially now that the package is in Debian/Ubuntu and breaking the ABI without a proper (major or minor) version bump is not acceptable for the Linux distributions.

dirk-thomas commented 10 years ago

Can you please provide some more information - which change in rosconsole broke ABI compatibility of console_bridge?

jbohren commented 10 years ago

Can you please provide some more information - which change in rosconsole broke ABI compatibility of console_bridge?

I'm not sure. This was a month ago and after updating the hydro debians I had to recompile all of my code due to some linker error in rosconsole. You can probably close this because I'm really not sure how to repro.

richmattes commented 10 years ago

Commit 53c81ac0cf8ca1884bfc3aa7c1de847ad4b25934 would have resulted in breakage requiring all users of libconsole_bridge.so to re-link and pick up the new SONAME. Why was the SOVERSION removed?

isucan commented 10 years ago

At least at the time, that prevented bloom from finding the library at deb build time.

On Sat, Aug 23, 2014 at 9:36 AM, Rich notifications@github.com wrote:

Commit 53c81ac https://github.com/ros/console_bridge/commit/53c81ac0cf8ca1884bfc3aa7c1de847ad4b25934 would have resulted in breakage requiring all users of libconsole_bridge.so to re-link and pick up the new SONAME. Why was the SONAME removed?

— Reply to this email directly or view it on GitHub https://github.com/ros/console_bridge/issues/14#issuecomment-53158001.

richmattes commented 10 years ago

That sounds like it might have been a bug where the libconsole-bridge-dev package wasn't getting installed but libconsole-bridge was. Removing the soversion could have made it so that the library libconsole_bridge.so ended up in the base package instead of libconsole-bridge.so.0.2 being in the base package and the unversioned symlink libconsole_bridge.so being in the -dev package.

scpeters commented 8 years ago

I think we can close this. Are there any lingering issues here?

scpeters commented 8 years ago

I'm closing this as it seems to be resolved. Please reopen if the issue persists.