search

ros / console_bridge

A ROS-independent package for logging that seamlessly pipes into rosconsole/rosout for ROS-dependent packages.
BSD 3-Clause "New" or "Revised" License
22 stars 62 forks source link

Use cmake FULL variables for pkgconfig libdir and includedir #29

Closed j-rivero closed 8 years ago

j-rivero commented 8 years ago

Back to use the FULL cmake variables. It was removed in 27de5f2f607c6d5b6aae66175503d7e56729a2b7

scpeters commented 8 years ago

It looks like they were using CMAKE_INSTALL_LIBDIR and CMAKE_INSTALL_INCLUDEDIR before, not the FULL versions. What is the difference?

j-rivero commented 8 years ago

It looks like they were using CMAKE_INSTALL_LIBDIR and CMAKE_INSTALL_INCLUDEDIR before, not the FULL versions. What is the difference?

When using GNUInstallDirs, the FULL variables represent absolute path. From that file:

# Each CMAKE_INSTALL_FULL_<dir> value contains an absolute path constructed
# from the corresponding destination by prepending (if necessary) the value
# of CMAKE_INSTALL_PREFIX.
scpeters commented 8 years ago

@jpgr87 what do you think?

richmattes commented 8 years ago

It's basically equivalent to ${prefix}/@CMAKE_INSTALL_*, I think it's fine to do it this way.

scpeters commented 8 years ago

+1

thanks @j-rivero and @jpgr87