search

ros / console_bridge

A ROS-independent package for logging that seamlessly pipes into rosconsole/rosout for ROS-dependent packages.
BSD 3-Clause "New" or "Revised" License
22 stars 62 forks source link

Build broken on Windows #34

Closed gerkey closed 8 years ago

gerkey commented 8 years ago

We're seeing a build failure in console_bridge on Windows (http://ci.ros2.org/job/packaging_windows/114/consoleFull#console-section-37):

ClCompile:
  C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\bin\x86_amd64\CL.exe /c /I<http://ci.ros2.org/job/packaging_windows/ws/ws\src\vendor\console_bridge\include> /I<http://ci.ros2.org/job/packaging_windows/ws/ws\src\vendor\console_bridge\test\gtest\include> /I<http://ci.ros2.org/job/packaging_windows/ws/ws\src\vendor\console_bridge\test\gtest> /I<http://ci.ros2.org/job/packaging_windows/ws/ws\src\vendor\console_bridge\test> /nologo /W3 /WX- /O2 /Ob2 /D WIN32 /D _WINDOWS /D NDEBUG /D "CMAKE_INTDIR=\"Release\"" /D _MBCS /Gm- /EHsc /MD /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"console_TEST.dir\Release\\" /Fd"console_TEST.dir\Release\vc140.pdb" /Gd /TP /errorReport:queue  -Wno-deprecated-declarations <http://ci.ros2.org/job/packaging_windows/ws/ws\src\vendor\console_bridge\test\console_TEST.cc>
cl : Command line error D8021: invalid numeric argument '/Wno-deprecated-declarations' [<http://ci.ros2.org/job/packaging_windows/ws/ws\build\console_bridge\test\console_TEST.vcxproj]>

I'm not an expert, but it looks like the MSVC compiler doesn't accept Wno-deprecated-declarations. It's not on their apparently exhaustive list: https://msdn.microsoft.com/en-us/library/fwkeyyhe.aspx.

Perhaps the setting of that option should be conditioned on platform so that it's not used on Windows: https://github.com/ros/console_bridge/blob/master/test/CMakeLists.txt#L26-L27.