search

ros / console_bridge

A ROS-independent package for logging that seamlessly pipes into rosconsole/rosout for ROS-dependent packages.
BSD 3-Clause "New" or "Revised" License
22 stars 62 forks source link

Make CMake configuration files relocatable #45

Closed traversaro closed 7 years ago

traversaro commented 7 years ago

See discussion in https://github.com/ros/console_bridge/issues/44 .

mikaelarguedas commented 7 years ago

:+1:

Tested this PR with ros2 and it solves the problem of not being able to find console_bridge.

(The original problem being the console_bridge-config.cmake file keeps an absolute path of the building machine for include and library folders. So it cannot be deployed to another location or another machine with a different folder structure)

nuclearsandwich commented 7 years ago

@mikaelarguedas will this PR be necessary for console_bridge in beta2? It seems like it should be.

mikaelarguedas commented 7 years ago

@nuclearsandwich Sorry I forgot to reply to that after we discussed it offline. Yes this needs to be in if we want users to be able to build packages on top of our binaries / archives. The only scenario it would work without this change is for linux users using debian packages.

@j-rivero @scpeters any chance to get this reviewed and merged in the near future?

nuclearsandwich commented 7 years ago

any chance to get this reviewed and merged in the near future?

Review would certainly be welcome and I'd love to get back to tracking master for future releases, but this would not block beta2 if it waited since the packaged build is based my branch here: https://github.com/ros/console_bridge/pull/46 which incorporates this branch as well as some others.

mikaelarguedas commented 7 years ago

since the packaged build is based my branch here: #4

It's only the deb packaging jobs right? not the packaging jobs for the other platforms? I agree we could track that in the meantime

scpeters commented 7 years ago

sorry for the delay in reviewing, this looks great!