This package started using targets in #45, which almost helps with issue #52, but the targets can get confused with library names, since the console_bridge_LIBRARIES variable is console_bridge, then target_link_libraries(${console_bridge_LIBRARIES}) will just try to link to the library instead of the target ( https://github.com/dartsim/dart/issues/1200 ). Adding a namespace ensures that target_link_libraries will link to the target and propagate the full library path to downstream code, which should help fix https://github.com/dartsim/dart/issues/1200.
nuclearsandwich
commented
5 years ago
This package started using targets in #45, which almost helps with issue #52, but the targets can get confused with library names, since the
console_bridge_LIBRARIESvariable isconsole_bridge, thentarget_link_libraries(${console_bridge_LIBRARIES})will just try to link to the library instead of the target ( https://github.com/dartsim/dart/issues/1200 ). Adding a namespace ensures thattarget_link_librarieswill link to the target and propagate the full library path to downstream code, which should help fix https://github.com/dartsim/dart/issues/1200.