search

ros / console_bridge

A ROS-independent package for logging that seamlessly pipes into rosconsole/rosout for ROS-dependent packages.
BSD 3-Clause "New" or "Revised" License
22 stars 62 forks source link

Add in tests. #71

Closed clalancette closed 4 years ago

clalancette commented 4 years ago

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

This just adds in basic tests for all of the functions in console.h. I'm not going to claim that it gives 100% test coverage, but it at least gives us basic confidence that things are working.

clalancette commented 4 years ago

For QL2 we need to test all features, Do you mind to add the features in the README.md ?

Done in 85b376b . Let me know if that covers it for you.

(as a side note, I didn't know about the captureStdout feature of gtest that you used in #74. Good to know for the future!)

Blast545 commented 4 years ago

May I ask you to check DCO is working by making a "dummy" modification commit before merging? It was enabled recently.

Blast545 commented 4 years ago

Nvm, this was tested with latest #73 commit, feel free to merge.