search

ros / console_bridge

A ROS-independent package for logging that seamlessly pipes into rosconsole/rosout for ROS-dependent packages.
BSD 3-Clause "New" or "Revised" License
22 stars 62 forks source link

Make sure to export include directories. #72

Closed clalancette closed 4 years ago

clalancette commented 4 years ago

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

With this in place, the exported console_bridge-targets.cmake now contains a stanza like:

set_target_properties(console_bridge::console_bridge PROPERTIES
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include"
)

which is needed by downstream consumers to build against this package.

clalancette commented 4 years ago

@scpeters Please hold on this one; I'm still doing some debugging on it. In point of fact, I'll turn it into a draft PR for now.

clalancette commented 4 years ago

All right, it turns out we need this one as-is, so I'm converting it back to an open PR.