search

ros / console_bridge

A ROS-independent package for logging that seamlessly pipes into rosconsole/rosout for ROS-dependent packages.
BSD 3-Clause "New" or "Revised" License
22 stars 62 forks source link

removes -lpthread when building for QNX #88

Closed asobhy-qnx closed 4 years ago

asobhy-qnx commented 4 years ago

part of the work done for QNX support https://github.com/ros2/ros2/issues/988

codecov-commenter commented 4 years ago

Codecov Report

Merging #88 into master will increase coverage by 33.33%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #88       +/-   ##
===========================================
+ Coverage   65.00%   98.33%   +33.33%     
===========================================
  Files           2        2               
  Lines          60       60               
===========================================
+ Hits           39       59       +20     
+ Misses         21        1       -20
Impacted Files Coverage Δ
src/console.cpp 98.21% <0.00%> (+35.71%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0a6c16e...6b2bd29. Read the comment docs.

asobhy-qnx commented 4 years ago

@dirk-thomas

scpeters commented 4 years ago

thanks for the patch!