Make exported target use CMAKE_INSTALL_INCLUDEDIR

ros / console_bridge

A ROS-independent package for logging that seamlessly pipes into rosconsole/rosout for ROS-dependent packages.

BSD 3-Clause "New" or "Revised" License

22 stars 62 forks source link

Make exported target use CMAKE_INSTALL_INCLUDEDIR #94

Closed sloretz closed 2 years ago

sloretz commented 2 years ago

This fixes a bug where the exported target had hard coded include instead of ${CMAKE_INSTALL_INCLUDEDIR}. This bug would only be an issue if a user manually specified a different include directory on the command line to cmake.

scpeters commented 2 years ago

This looks good to me. @scpeters could you take a look at this, and if you approve, merge and do a new tag for this package?

I've merged this and opened https://github.com/ros/console_bridge/pull/95 in preparation for a release and added you as a reviewer

scpeters commented 2 years ago

This looks good to me. @scpeters could you take a look at this, and if you approve, merge and do a new tag for this package?

https://github.com/ros/console_bridge/releases/tag/1.0.2