search

ros / console_bridge

A ROS-independent package for logging that seamlessly pipes into rosconsole/rosout for ROS-dependent packages.
BSD 3-Clause "New" or "Revised" License
22 stars 62 forks source link

Provide PROJECT_SOURCE_DIR to cpplint #97

Closed nim65s closed 1 year ago

nim65s commented 2 years ago

to fix eg:


3/3 Test #3: console_bridge_cpplint3/3 Test #3: console_bridge_cpplint............***Failed    0.15 sec
…/src/console_bridge-1.0.2/include/console_bridge/console.h:37:  #ifndef header guard has wrong style, please use: SRC_CONSOLE_BRIDGE_1_0_2_INCLUDE_CONSOLE_BRIDGE_CONSOLE_H_  [build/header_guard] [5]
…/src/console_bridge-1.0.2/include/console_bridge/console.h:192:  #endif line should be "#endif  // SRC_CONSOLE_BRIDGE_1_0_2_INCLUDE_CONSOLE_BRIDGE_CONSOLE_H_"  [build/header_guard] [5]
nim65s commented 1 year ago

Hi,

This is a gentle ping. Is there anything missing here ?

traversaro commented 1 year ago

fyi @scpeters per https://github.com/ros/console_bridge/pull/96#issuecomment-1106542011

nim65s commented 1 year ago

Oh, I see. Thanks @traversaro !