search

ros / dynamic_reconfigure

BSD 3-Clause "New" or "Revised" License
48 stars 111 forks source link

Misorder of SYSTEM/BEFORE option in include_directories in cmake/dynamic_reconfigure-macros.cmake #150

Closed hexonxons closed 4 years ago

hexonxons commented 4 years ago

There is an error introduced in commit https://github.com/ros/dynamic_reconfigure/commit/c70637975dc7cd8f765efb6bd8fd57b1f0a75d05 at line https://github.com/ros/dynamic_reconfigure/blob/c70637975dc7cd8f765efb6bd8fd57b1f0a75d05/cmake/dynamic_reconfigure-macros.cmake#L118

According to include_directories documentation [SYSTEM] options must follow [AFTER|BEFORE] options. Due to this I have nice error: cc1plus: error: /home/hexonxons/some/path/project_name/BEFORE: No such file or directory [-Werror=missing-include-dirs]

hexonxons commented 4 years ago

@mjcarroll Could you possibly review PR and release a fixed version to melodic asap?

mjcarroll commented 4 years ago

Good catch, thanks for the patch.

ros-discourse commented 4 years ago

This issue has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/preparing-for-melodic-sync-2020-03-12/13207/12