search

ros / dynamic_reconfigure

BSD 3-Clause "New" or "Revised" License
47 stars 112 forks source link

Revert #140 #152

Closed mjcarroll closed 4 years ago

mjcarroll commented 4 years ago

We discovered that there is an issue when building overlays with this in place. This didn't show up in the normal CI process where we don't overlay. The SYSTEM parameter causes gcc to use -isystem, which does suppress warnings as the PR intended, but it also re-orders the include paths, which can cause overlays to break.

Signed-off-by: Michael Carroll michael@openrobotics.org

ros-discourse commented 4 years ago

This issue has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/preparing-for-melodic-sync-2020-03-12/13207/11

ros-discourse commented 4 years ago

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/preparing-for-melodic-sync-2020-03-20/13306/1

ros-discourse commented 4 years ago

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/new-packages-for-melodic-2020-03-22/13329/5

paulbovbel commented 3 years ago

@mjcarroll this also breaks overlays in noetic-devel, could the same revert be applied there please?

knorth55 commented 3 years ago

+1 for @paulbovbel I want this PR to be ported to noetic branch, too.