search

ros / dynamic_reconfigure

BSD 3-Clause "New" or "Revised" License
48 stars 111 forks source link

WIP: Python3 migration #156

Open kmfrick opened 4 years ago

kmfrick commented 4 years ago

I'm migrating a codebase to python3 and noticed dynamic_reconfigure still used python2, making my control pipeline go bonkers. Right now I don't have the time to do extensive testing, this is basically just running 2to3 and s/file(/open(, but my control pipeline now works. Any review is welcome :)

mikaelarguedas commented 4 years ago

@kmfrick a similar PR was merged at https://github.com/ros/dynamic_reconfigure/pull/157 Does it solve your problem as well ?

kmfrick commented 4 years ago

Pardon me, I haven't had time to check it yet. I will try my control pipeline with the updated noetic-devel branch in the weekend and close the PR if #157 solves the issue!