Fix python3 issue in a backward compatible way - Githubissues

ros / dynamic_reconfigure

BSD 3-Clause "New" or "Revised" License

48 stars 111 forks source link

Fix python3 issue in a backward compatible way #157

Closed mikaelarguedas closed 4 years ago

mikaelarguedas commented 4 years ago

This PR is written to be backportable to other ROS distributions. It fixes 2 issues I faced trying to use dynparam in ROS Noetic

shebang line issue: /usr/bin/env: ‘python’: No such file or directory
NameError: name 'file' is not defined

This is a less intrusive alternative to https://github.com/ros/dynamic_reconfigure/pull/156

This PR also removes the placeholder script reconfigure_gui that has been introduced as a deprecation warning for the groovy release https://github.com/ros/dynamic_reconfigure/commit/1d3f3d5562f959b96f596458f8a43b87be6f6e22

ros-discourse commented 4 years ago

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-noetic-ninjemys-release/14262/22