search

ros / dynamic_reconfigure

BSD 3-Clause "New" or "Revised" License
47 stars 112 forks source link

set ns as '~' when namespace is '~' #169

Closed knorth55 closed 1 year ago

knorth55 commented 3 years ago

when we pass namespace='~' in dynamic_reconfigure.Server, self.ns is set as ~/. dynamic_reconfigure.Server makes /set_parameters service with self.ns = ~/, which causes the issue below in rqt_reconfigure. https://github.com/ros-visualization/rqt_reconfigure/issues/92

self.ns should be ~ when namespace='~' or namespace='', so I made this PR. I'm not super confident in this PR, so I want to do discussion about this feature.

Signed-off-by: Michael Carroll michael@openrobotics.org

knorth55 commented 3 years ago

I change this PR target to noetic-devel branch.

knorth55 commented 3 years ago

can anyone please review and merge this PR?

knorth55 commented 3 years ago

can anyone please review and merge this PR?

knorth55 commented 2 years ago

kindly ping. can anyone review and merge this PR?

knorth55 commented 1 year ago

@gbiggs can you also check this PR, too?

gbiggs commented 1 year ago

Thanks for the contribution!