cmake_scripts: "BEFORE" must come before the "SYSTEM"

ros / dynamic_reconfigure

BSD 3-Clause "New" or "Revised" License

48 stars 111 forks source link

Closed bin-i closed 2 years ago

bin-i commented 3 years ago

https://cmake.org/cmake/help/latest/command/include_directories.html [AFTER|BEFORE] must come before the "SYSTEM". There is a bug -isystem .../BEFORE cc1plus: error: .../BEFORE: No such file or directory [-Werror=missing-include-dirs]

adivardi commented 3 years ago

any maintainer available to quickly review this? This solves a compiler error when -Werror=missing-include-dirs is enabled.

Michael-Purser commented 3 years ago

It would indeed be great if this could get merged soon!

ros-discourse commented 2 years ago

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

bin-i commented 2 years ago