search

ros / dynamic_reconfigure

BSD 3-Clause "New" or "Revised" License
48 stars 111 forks source link

do not use system for generated configs #182

Closed knorth55 closed 2 years ago

knorth55 commented 2 years ago

This is a backport of #152 to noetic branch.

This PR fixes the issue introduced in #140.

with #140, generated messages are inluded as SYSTEM, -isystem. however this means that if /opt/ros/noetic/include is included with -I, compiler uses /opt/ros/noetic/include one. this issue causes build error when we install same package both with debian package and workspace. Now noetic-devel branch uses /opt/ros/noetic/include instead of devel/.private/<package name>/include because of -isystem. therefore, I move back to previous one -I to fix this issue with this PR.

Related #152

ros-discourse commented 2 years ago

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/dynamic-reconfigure-maintenance/21950/1

k-okada commented 2 years ago

@mjcarroll Could you release this as 1.7.2 into noetic? Thanks in advance.

seebq commented 2 years ago

Ran into this bug on our production field units that have system installed packages with messages via debian packages, and a local workspace.

Adding generate_dynamic_reconfigure_options macro makes our build look for the system installed Debians over the local workspace, resulting in build errors.

This fix confirms fixing. I saw we just did a small noetic release but this wasn't included. I also noticed this isn't on the bloom-release system (i.e. no -release repo). How can we assist in getting this into 1.7.2 into noetic?

CC @kakaday22 at Greenzie .

gbiggs commented 2 years ago

1.7.2 has been released. Look for it in the next sync.